codegen: Update API client to include package docs #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds generation of Go package does for API client packages. This takes the API client service model's "description" and uses it as the package doc for the API client package.
JordonPhillips
requested changes
Oct 14, 2020
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/CodegenUtils.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/GoWriter.java
Outdated
Show resolved
Hide resolved
JordonPhillips
approved these changes
Oct 14, 2020
skmcgrail
approved these changes
Oct 15, 2020
skotambkar
approved these changes
Oct 15, 2020
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Oct 15, 2020
Regenerates SDK API clients based on codegen change aws/smithy-go#216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generation of Go package does for API client packages. This takes the API client service model's "description" and uses it as the package doc for the API client package.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.